Smoothing gem #48
Merged
Smoothing gem #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michalpelka
force-pushed
the
mp/smoothing_gem
branch
4 times, most recently
from
9670951
to
bd24e65
Compare
patrykantosz
approved these changes
Aug 14, 2024
There was a problem hiding this comment.
Great job, smoothing component works as expected. Just some minor comments. Also I've noticed something strange - when I tried to enable this gem in my project I got something like this:
[ERROR] o3de.enable_gem: Smoothing has the following dependency compatibility issues and requires the --force parameter to activate: The following dependency requirements could not be satisfied: The project requires RobotecSpectatorCamera
It's strange becasue grep -rns ".*Spectator.*" ./Smoothing returns empty list. Could you check this on your setup?
michalpelka
commented
Aug 20, 2024
michalpelka
commented
Aug 20, 2024
The gem allows user to smooth movement of the entity. It provides two types of smoothing: simple and damping. Co-authored-by: Patryk Antosz <[email protected]> Signed-off-by: Michał Pełka <[email protected]>
michalpelka
force-pushed
the
mp/smoothing_gem
branch
from
7474436
to
1a0805e
Compare
|
Thanks for review @patrykantosz ! I've updated PR, applied all your suggestions. I also squashed multiple commits. |
patrykantosz
approved these changes
Aug 21, 2024
michalpelka
commented
Aug 21, 2024
michalpelka
commented
Aug 21, 2024
michalpelka
commented
Aug 21, 2024
|
Are we going to merge it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gem that allows to smooth movement of the entity.